GraphQL Aliases on relational value

[DamienMrtl]

Describe the Bug

When using alias in a graphqQL query on a junction table the returned value of the field using the alias is null. When I remove the alias from the query the data is there.

To Reproduce

1. Two collections with a m2m relation to get a junction table.
2. Use graphQL to query nested data from both collections.
3. Add an alias on the junction table field in the graphQL query.

What version of Directus are you using?

9.0.0-rc95

What version of Node.js are you using?

14.17.5

What database are you using?

Postgres 13.2

What browser are you using?

Chrome

What operating system are you using?

Windows

How are you deploying Directus?

Jelastic

[azrikahar]

Can confirm this bug is present, and seems like #8332 was correct in that aliases are broken since rc.94 (even though we couldn't replicate it back then).

Managed to narrow it down to this bug being introduced in #8009's api/src/services/graphql.ts as reverting that specific file only makes aliases work again.

[filipproch]

I managed to narrow it down to the line (api/src/services/graphql.ts)
1378 current = selection.alias?.value ?? selection.name.value;

removing the part
selection.alias?.value ??
fixes the issue

[rijkvanzanten]

Wanna open a PR with that fix @filipproch? 🙂

[filipproch]

@rijkvanzanten sure, would there be an appropriate place to also create a test case for future?

[filipproch]

Also one more edit is needed,
now
[415] return obj[info?.path?.key ?? field.field];
to make it work
[415] return obj[field.field];

both edits are required to make it work
first => to get the value of the field from DB, second - to correctly resolve it in the query

[rijkvanzanten]

We've just started an effort to setup test cases for more and more bits of the API, but I don't think the GraphQL endpoint / services have something spun up yet, right @jaycammarano?

[jamescammarano]

We've just started an effort to setup test cases for more and more bits of the API, but I don't think the GraphQL endpoint / services have something spun up yet, right @jaycammarano?

No. That was on my notes to discuss. Was thinking of probably doing e2e for REST and integration for GraphQL? Just so there's not a ton of repetition in the e2e tests.

[filipproch]

Ok will send PR with just the fix then

[cdanny358]

Unfortunately, this fix seems to have broken other things. Now aliases to simple fields return the error message "Cannot destructure property 'type' of 'field' as it is undefined," and aliases to many-to-one fields return null, which was the original problem I was seeing. I'm in version rc.99.

[filipproch]

@cdanny358 I will look into it further then and invent a better solution

[iksent]

I can confirm this bug exists in RC100.

Cannot destructure property 'type' of 'field' as it is undefined.

My code:

query siteMapContests {
  contest(limit: 100) {
    s: slug # <<< Works OK without renaming "s: "
  }
}

Should we reopen this one or open a new issue?

[rijkvanzanten]

A new issue would be most helpful @iksent 👍🏻

[filipproch]

@iksent And feel free to mention me, I plan to submit a PR this week

[rijkvanzanten]

Awesome, thank you!