Fix compatibility with Postgres <= 10 #10139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oreilles
changed the title
cah4a
reviewed
Nov 30, 2021
cah4a
reviewed
Nov 30, 2021
cah4a
reviewed
Nov 30, 2021
|
@cah4a This PR fixes the OP in the referenced ticket, so I'll merge it for now. Mind opening a new Issue / PR with any comments / concerns you have on that dialects/postgres file? 🙂 As @Oreilles mentioned, it seems like some of your comments aren't related to anything that changed in this PR in particular, so are better suited for a follow up sprint 👍🏻 |
rijkvanzanten
approved these changes
Dec 1, 2021
rijkvanzanten
added a commit
that referenced
this pull request
Dec 1, 2021
* Use indnatts instead of indnkeyatts in postgres dialect * Update knex-schema-inspector * Add PG10 for debugging Co-authored-by: rijkvanzanten <rijkvanzanten@me.com>
|
@rijkvanzanten just took my eye. |
|
@cah4a What do you mean? I'm very interested to hear more about the points you've found! Just saying that a separate issue w/ pull request review cycle is a better place to discuss optimizations to code that already existed before the changes in this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10136
Comes with knex/knex-schema-inspector#89