refresh edited insights panel on change #10180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
licitdev
reviewed
Dec 1, 2021
azrikahar
commented
Dec 1, 2021
rijkvanzanten
requested changes
Dec 1, 2021
rijkvanzanten
approved these changes
Dec 1, 2021
rijkvanzanten
added a commit
that referenced
this pull request
Dec 1, 2021
* refresh edited insights panel on change * move api simpleHash to shared utils getSimpleHash * Simply reactivity fix for time-series * Remove unused import Co-authored-by: rijkvanzanten <rijkvanzanten@me.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10177
Before
After a panel gets staged/created, it will not change even when we modify any settings, and we'll have to refresh to see the changes:
hy1L6WRoAh.mp4
After
Uses Vue key to re-render the panel whenever any property gets changed, except position x/y and coordinates to prevent re-render when the user is only moving them around.
y8GNH0tXgF.mp4