Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SQLite date functions not working in aggregate queries #10270

Merged
merged 1 commit into from Dec 3, 2021
Merged

Fix SQLite date functions not working in aggregate queries #10270

merged 1 commit into from Dec 3, 2021

Conversation

Oreilles
Copy link
Contributor

@Oreilles Oreilles commented Dec 3, 2021

Fixes #10253
node-sqlite stores dates as milliseconds since the epoch, so we need to process them before using strftime.

@rijkvanzanten rijkvanzanten self-assigned this Dec 3, 2021
@rijkvanzanten rijkvanzanten added this to the v9.1.3 milestone Dec 3, 2021
@rijkvanzanten rijkvanzanten enabled auto-merge (squash) December 3, 2021 14:54
@rijkvanzanten rijkvanzanten merged commit 8ed5177 into main Dec 3, 2021
@rijkvanzanten rijkvanzanten deleted the fix/10253-sqlite-date-fn branch December 3, 2021 14:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rijkvanzanten rijkvanzanten rijkvanzanten approved these changes

Assignees

@rijkvanzanten rijkvanzanten

Labels
🍰 Bug 🕋 SQLite
Projects
None yet
Milestone
v9.2.0
Development

Successfully merging this pull request may close these issues.

Time series insight doesn't work on SQLite DB
2 participants
@Oreilles @rijkvanzanten