Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSO fixes and improvements #10301

Merged
merged 6 commits into from Dec 6, 2021
Merged

SSO fixes and improvements #10301

merged 6 commits into from Dec 6, 2021

Conversation

aidenfoxx
Copy link
Contributor

@aidenfoxx aidenfoxx commented Dec 4, 2021

Sorry for bundling things together. I can split them out if required.

  • Fixes OIDC: refresh grant improperly handles new refresh_token #10233 (update refresh_token if one is provided in the refresh() call)
  • Added ability to set custom authorization URL parameters
  • Added ability to specify issuerUrl in OAuth2 flow (required when using OpenID)
  • Added handling for if refresh_token is invalidated
    1. During login we trigger a refresh to verify the refresh_token validity
    2. On InvalidTokenException trigger the SSO authorization page with a prompt=consent to request a new refresh_token
    3. Fail if token continues to be invalid

@rijkvanzanten
Copy link
Member

LGTM!

@rijkvanzanten rijkvanzanten merged commit f48a413 into directus:main Dec 6, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OIDC: refresh grant improperly handles new refresh_token
2 participants