Relations: fix M2M related primary key #10368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 7, 2021
When relation PK is a manually entered string, we cannot rely on relation PK.
joselcvarela
force-pushed
the
m2m-bug-fix
branch
from
a0d0115
to
c0905cb
Compare
joselcvarela
approved these changes
Dec 10, 2021
joselcvarela
changed the title
rijkvanzanten
approved these changes
Dec 10, 2021
3 tasks
3 tasks
This was referenced Dec 17, 2021
This was referenced Jan 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Cause & Solution
In many to many relationships, 2 tables have relationships using the 3rd intermediate table. And mostly the primary key is set as
idonly so it missed to set the primary key of the relational table instead of the junction table. So it’s causing an issue when we set the primary key of the relational table to something else (and notid).I’ve changed that as expected and it’s working now.
*Special Thanks - to @Vishalsag for helping me in debugging the issue.
Fixes #8417
Fixes #9923