Check for required fields on create

[azrikahar]

Fixes #10610

Before

Here the "description" field is set as required, but we can still create new item via GraphQL or REST without it.

There's no ! appended to String for "description", thus interpreted as nullable:

input create_bar_input {
  id: ID
  name: String
  description: String
}

And we can create it successfully without "description":

After

• Added check for required value in fields and set them as non-nullable in GraphQL:

  input create_bar_input {
    id: ID
    name: String
    description: String!
  }

  

• Added the same check to REST API:

  

---

IIRC there was a discussion/issue about required being App only, though I can't recall whether that is intended or not.

Update: on hindsight, this will break for conditional fields that manipulate "required" right? Not sure how can we mitigate that. This might have been the reason why "required" is App only now. @rijkvanzanten Could this change be the wrong direction?

[azrikahar]

As mentioned in the last part of this PR:

on hindsight, this will break for conditional fields that manipulate "required"

this solution is not accounting for conditions on the App side, so opting to close this PR.