Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing 'version' to Knex #10960

Merged
merged 2 commits into from
Jan 10, 2022
Merged

Allow passing 'version' to Knex #10960

merged 2 commits into from
Jan 10, 2022

Conversation

joeinnes
Copy link
Contributor

Fixes #10941 by treating DB_VERSION as a special env var which needs to be added to the top level Knex configuration rather than merged into the connection object.

rijkvanzanten
rijkvanzanten requested changes Jan 10, 2022
View reviewed changes
Copy link
Member

@rijkvanzanten rijkvanzanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets also explicitly exclude that flag on line 22 to make sure we don't accidentally pass it into config as well 👍🏻

@rijkvanzanten rijkvanzanten self-assigned this Jan 10, 2022
@rijkvanzanten rijkvanzanten added this to the v9-next milestone Jan 10, 2022
@rijkvanzanten rijkvanzanten enabled auto-merge (squash) January 10, 2022 17:17
@rijkvanzanten rijkvanzanten merged commit 987442c into directus:main Jan 10, 2022
@joeinnes joeinnes deleted the fix-10941 branch January 10, 2022 18:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rijkvanzanten rijkvanzanten rijkvanzanten approved these changes

Assignees

@rijkvanzanten rijkvanzanten

Labels
🍰 Improvement
Projects
None yet
Milestone
v9.5.0
Development

Successfully merging this pull request may close these issues.

Can't pass a version to Knex
2 participants
@joeinnes @rijkvanzanten