fix tooltip directive modifiers #11263

azrikahar · 2022-01-25T13:24:23Z

Reported Bug

Tooltip with bottom.end modifier is still showing up as top, particularly in latency indicator:

#10977 added the following code:

Lines 87 to 88 in f255222

    
           if ('start' in binding.modifiers) placement = 'start'; 
        
           if ('end' in binding.modifiers) placement = 'end';

However I believe the valid values for placement are only top, bottom, left, and right.

azrikahar added 2 commits January 25, 2022 21:16

fix tooltip directive modifiers

37b3fa8

update tooltip readme

07ce408

azrikahar added App 🍰 Bug labels Jan 25, 2022

rijkvanzanten added this to the v9-next milestone Jan 25, 2022

rijkvanzanten self-assigned this Jan 25, 2022

rijkvanzanten approved these changes Jan 25, 2022

View reviewed changes

rijkvanzanten merged commit 5b80642 into main Jan 25, 2022

rijkvanzanten deleted the issue/11260 branch January 25, 2022 14:25

azrikahar mentioned this pull request Jan 26, 2022

Connection Info is not displayed properly #11288

Closed

3 tasks

github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024

	if ('start' in binding.modifiers) placement = 'start';
	if ('end' in binding.modifiers) placement = 'end';