Resolve transaction unreliability issues in schema alterations #11279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent dead roaches
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CockroachDB doesn't support doing schema changes in transactions after a regular write. SQLite doesn't support nested transactions, MySQL simply ignores transactions altogether when doing schema operations.
Long story short, we can't reliably rely on transactions in schema changes (eg /collections, /fields, and /relations). This PR is the start of a (bigger) change to effectively remove the usage of transactions in schema operations, in favor of doing proper validation before doing the schema alterations.Scratch that. Seems like simply doing the schema operation first in the transaction makes all vendors play nicely ✨
Fixes #11280