Prevent group edited indicator in Shared View #11284
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Currently groups in the Shared View shows the dot beside their label, but it shouldn't be the case as it's a read-only view:
(Detail group will only show the dot when it's closed, hence it's not shown here)
Investigation
This happens because shared view is passing the
item
intov-model
as well:directus/app/src/routes/shared/components/share-item.vue
Lines 2 to 9 in 4e68cd2
Whereas as shown in collection items,
edits
should be the one passed tov-model
:directus/app/src/modules/content/routes/item.vue
Lines 149 to 160 in 4e68cd2
Solution
Initially removed the v-model flat out, but later on opted to use
edits
like the existing form in collection items in case editing shared item became possible in the future.