Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sorting of select-multiple-dropdown values #11289

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Conversation

azrikahar
Copy link
Contributor

Fixes #10639

Before

When we do the following:

  1. untick & tick Bold again
  2. tick Background Color
  3. tick Foreground Color

The expectation is these 3 will be at the start of the toolbar. However currently they end up at the last positions instead based on our tick order:

BiMwvRMlmh.mp4

After

ORfR4B4Jil.mp4

@benhaynes
Copy link
Sponsor Member

Nice!! Since you're in this code, is it possible to predefine a proper order for these wysiwyg buttons that matches most editors?

Typically bold, italic, and underline would come first, etc...

It'd be cool if these formatting options were manually reorderable... but that's for another day.

@azrikahar
Copy link
Contributor Author

Sure thing 👍 Tried to cross reference it among other WYSIWYG editors but came across this TinyMCE example:

chrome_4Lo5d2STLj

(from https://codepen.io/tinymce/pen/qBWLLMP)

Is this ordering okay?

@benhaynes
Copy link
Sponsor Member

Looks great! Thank you...

@rijkvanzanten
Copy link
Member

@azrikahar lets put that change on a new pr 👍🏻

@rijkvanzanten rijkvanzanten merged commit 9d7b3f2 into main Jan 26, 2022
@rijkvanzanten rijkvanzanten deleted the issue/10639 branch January 26, 2022 12:55
@rijkvanzanten rijkvanzanten added this to the v9-next milestone Jan 26, 2022
@rijkvanzanten rijkvanzanten self-assigned this Jan 26, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WYSIWYG header buttons are added in order checkboxes were selected
3 participants