Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue when updating columns in Oracle #11359

Merged
merged 3 commits into from
Jan 31, 2022
Merged

Fixed issue when updating columns in Oracle #11359

merged 3 commits into from
Jan 31, 2022

Conversation

aidenfoxx
Copy link
Contributor

@aidenfoxx aidenfoxx commented Jan 31, 2022

Fixes an issue with Oracle where you are unable to alter a column if you don't change it's nullability. Oracle will reject the update query if it tries to set the same nullability as is already set on the column. The solution is to skip setting the nullable constraint if it is unchanged (the same as the is_unique constraint below it).

@rijkvanzanten rijkvanzanten added this to the v9-next milestone Jan 31, 2022
@rijkvanzanten rijkvanzanten self-assigned this Jan 31, 2022
@rijkvanzanten rijkvanzanten merged commit 4e0c27d into directus:main Jan 31, 2022
@rijkvanzanten rijkvanzanten deleted the patch-20 branch January 31, 2022 18:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants