Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix roles in users module navigation not updating #11501

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Fix roles in users module navigation not updating #11501

merged 1 commit into from
Feb 16, 2022

Conversation

azrikahar
Copy link
Contributor

Closes #11350

  • Always fetch roles now
  • Made sure loading state doesn't show for subsequent fetches. This way it doesn't really change if nothing has changed, but updates in place if there's any changes.

Before

oXkRzsj7nT

After

mfdPKP9cL5

@azrikahar azrikahar self-assigned this Feb 8, 2022
@rijkvanzanten rijkvanzanten added this to the v9-next milestone Feb 16, 2022
@rijkvanzanten rijkvanzanten merged commit 3211302 into main Feb 16, 2022
@rijkvanzanten rijkvanzanten deleted the issue/11350 branch February 16, 2022 14:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rijkvanzanten rijkvanzanten rijkvanzanten approved these changes

Assignees

@azrikahar azrikahar

Labels
🍰 Bug
Projects
None yet
Milestone
v9.5.2
Development

Successfully merging this pull request may close these issues.

Roles in Users Directory navigation are not updated after any changes to roles
2 participants
@azrikahar @rijkvanzanten