Add nested translations support #11672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11440
Context
Currently nested translation interfaces does not fetch/load items. This is due to the parent
<v-form>of the parent<translations>has theprimaryKeyprop (due to route param), but not the nested<v-form>s.Ref #11440 (comment) stating this was possible on V8, so this PR adds support to it.
Slightly concerned on the 80/20 rule or the current stance on this use case, but also can't see the "harm" of adding this since it should be a progressive enhancement and shouldn't affect other existing use cases to date.
Before
After