New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emoji Picker & Comment improvements #11946
Conversation
Nitwel
commented
Mar 4, 2022
•
edited
edited
Thanks, @Nitwel!! Here are a few things:
|
What browser are you using as it worked in Firefox?
You have to make sure that
We have that when editing a comment but what should it do when writing new comments? |
@benhaynes What exact version of chrome? Latest can mean 98, 99, or 100 depending on exact OS and other variables 🙇🏻♂️ |
Nils and I are discussing on Chat-A, going to switch to a more popular (powerful) Emoji library that solves all these issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future changes, lets do the refactor to script setup
in a separate PR. It's very difficult to see what you changed vs what was already there before
app/src/views/private/components/comments-sidebar-detail/comment-input.vue
Outdated
Show resolved
Hide resolved
app/src/views/private/components/comments-sidebar-detail/comment-input.vue
Show resolved
Hide resolved
app/src/views/private/components/comments-sidebar-detail/comment-item-header.vue
Outdated
Show resolved
Hide resolved
app/src/views/private/components/comments-sidebar-detail/comment-item.vue
Outdated
Show resolved
Hide resolved
app/src/views/private/components/comments-sidebar-detail/comment-item.vue
Show resolved
Hide resolved
I do not know why but for me there are only ??? without icon. |
* add simple emoji picker and improve comments * add v-md option to open in new tab * fix styling when editing comment * clean up code * use script setup * use different emoji lib * fix inserting emojis into text * fix search styling * always show cancel button * comment style tweaks * clean up emoji picker * add placeholder to v-template-input * cleanup comments some more * clean up comments sooooome more * fix notify message on update * update comment markdown styling * button and icon hover colors * move styling to global file * clean up code Co-authored-by: rijkvanzanten <rijkvanzanten@me.com> Co-authored-by: Ben Haynes <ben@rngr.org>