Delete field only after foreign key constraints are removed #13222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this should be related to #12478 |
Yes, tested and it does resolve that issue. Thanks! |
|
And can we add an e2e test for this too? 🙂 |
rijkvanzanten
requested changes
May 11, 2022
There was a problem hiding this comment.
@licitdev @azrikahar can you check if this doesn't break on CockroachDB? You can't do regular delete/inserts before a DDL statement in a transactions in CRDB, so this might go 💥 there
|
@rijkvanzanten The tests for creation and deletion of fields through API are included in the black box testing. Test Results Before & After PRBefore: https://github.com/directus/directus/runs/6384350766
|
rijkvanzanten
approved these changes
May 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix field deletion issue when the field is referenced by a foreign key constraint.
The dropping of the field now occurs only after the constraints are removed.
Issue exists for
mysql,mariaandmssql.Closes #12478.