Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use conditional props for component in v-button #13840

Merged
merged 3 commits into from Jun 17, 2022
Merged

Conversation

azrikahar
Copy link
Contributor

Description

After the dependency updates in #13713, <router-link>s are receiving the href prop even if it's undefined, which then causes the href it should have had (by using to) to be missing instead.

This uses v-bind to conditional pass href prop to prevent router-link from misbehaving.

Type of Change

  • Bugfix
  • New Feature
  • Refactor / codestyle updates
  • Other, please describe:

Requirements Checklist

  • New / updated tests are included
  • All tests are passing locally
  • Performed a self-review of the submitted code

If adding a new feature:

  • Documentation was added/updated

@azrikahar azrikahar marked this pull request as ready for review June 16, 2022 13:08
@rijkvanzanten rijkvanzanten added this to the v9-next milestone Jun 17, 2022
@rijkvanzanten rijkvanzanten self-assigned this Jun 17, 2022
@rijkvanzanten rijkvanzanten merged commit 6596bc1 into main Jun 17, 2022
@rijkvanzanten rijkvanzanten deleted the fix/router-links branch June 17, 2022 17:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants