Allows mustache syntax in numeric filters

[jamescammarano]

Description

Before:

Axis.-.Google.Chrome.2022-06-29.21-37-51.mp4

After:

Screen.Recording.2022-06-30.at.11.02.00.AM.mov

Note: This will allow mustache syntax across the entire app's use of system-filter even though this syntax is really only valuable to the Insights dashboard. If this is not ideal I can look for a different solution.

Fixes #14198

Type of Change

• Bugfix
• Improvement
• New Feature
• Refactor / codestyle updates
• Other, please describe:

Requirements Checklist

• New / updated tests are included
• All tests are passing locally
• Performed a self-review of the submitted code

If adding a new feature:

• Documentation was added/updated

[rijkvanzanten]

Am I misreading, or this function calling emit('input', val) for every case? If that's true, could this function not just simply be:

function emitValue(val: string) {
  if (val === '') return emit('input', null);
  emit('input', val);
}

[jamescammarano]

Am I misreading, or this function calling emit('input', val) for every case? If that's true, could this function not just simply be:

function emitValue(val: string) {
  if (val === '') return emit('input', null);
  emit('input', val);
}

is there a time when it wouldn't match:

if (typeof val !== 'string' || new RegExp(inputPattern.value).test(val)) {
	return emit('input', val);
}

UPDATE: Looks like it was changed in this PR #9376

To allow for dynamic variables

[licitdev]

@rijkvanzanten Should "multi tags" be allowable in the system filter context for insights? Eg: users can form custom strings {{var1}}_{{var2}}.

I wonder if a property should be added to allowVariables on system-filter.vue as it is currently only supported in insights. 🤔

The regex could be updated to along the lines of ({{[\w\d_]+?}}) as only alphanumeric characters and underscores are allowed.

[jamescammarano]

The regex should definitely be updated at the very least

[rijkvanzanten]

Seeing we're now using this interface inside insights options as well, it should support the multi-var style too yeah

[rijkvanzanten]

Heya, thanks for your PR! Our small team has been attempting to work through a backlog of external contributions for the better part of a year, but in that time many have become too stale to merge or the change is no longer desired/relevant..
We've updated the contributing guidelines and are working on making more resources available to make sure that doesn’t happen again 😬 In the meantime, we'll have to close this PR for now..