Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix date-fns format to use hours (HH) instead of era (GG) in polish translation #15032

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Fix date-fns format to use hours (HH) instead of era (GG) in polish translation #15032

merged 1 commit into from
Aug 11, 2022

Conversation

piotr-cz
Copy link
Contributor

Description

Polish translation uses GG instead of HH format:

date-fns_time_24hour: 'GG:mm:ss'
date-fns_time_no_seconds_24hour: 'GG:mm'

Reference: date-fns.org docs > format

Fixes #15031

Type of Change

  • Bugfix
  • Improvement
  • New Feature
  • Refactor / codestyle updates
  • Other, please describe:

Requirements Checklist

  • New / updated tests are included
  • All tests are passing locally
  • Performed a self-review of the submitted code

If adding a new feature:

  • Documentation was added/updated

@rijkvanzanten rijkvanzanten added this to the Next Release milestone Aug 11, 2022
@rijkvanzanten rijkvanzanten merged commit d3edacd into directus:main Aug 11, 2022
@piotr-cz
Copy link
Contributor Author

@rijkvanzanten
Thanks for quick merge, however this change should also be reflected in Crowdin so it's not overwritten by next Crowdin updates pull

@rijkvanzanten
Copy link
Member

Go for it! Everybody can contribute on Crowdin, and it'll auto-sync to the repo 👍🏻

@piotr-cz piotr-cz deleted the bugfix/translation-polish-time branch August 11, 2022 15:39
qborisb pushed a commit to qborisb/directus that referenced this pull request Aug 18, 2022
@piotr-cz @qborisb
Fix date-fns format to use hours (HH) instead of era (GG) (directus#1…
73cec82 
…5032)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rijkvanzanten rijkvanzanten rijkvanzanten approved these changes

Assignees
No one assigned
Labels
🍰 Improvement
Projects
None yet
Milestone
v9.16.0
Development

Successfully merging this pull request may close these issues.

Wrong translation in datetime interface for Polish language
2 participants
@piotr-cz @rijkvanzanten