Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop groups from rendering before the conditions are applied #15144

Merged
merged 3 commits into from
Aug 18, 2022

Conversation

br41nslug
Copy link
Member

Description

Groups were getting rendered before the form values were completely loaded causing the group to use default values preventing the "start open"/"start closed" options from being applied by conditions .

Fixes #15030

Type of Change

  • Bugfix
  • Improvement
  • New Feature
  • Refactor / codestyle updates
  • Other, please describe:

Requirements Checklist

  • New / updated tests are included
  • All tests are passing locally
  • Performed a self-review of the submitted code

If adding a new feature:

  • Documentation was added/updated

@rijkvanzanten rijkvanzanten merged commit b980345 into main Aug 18, 2022
@rijkvanzanten rijkvanzanten deleted the issue/15030 branch August 18, 2022 19:40
@licitdev licitdev added this to the Next Release milestone Aug 18, 2022
qborisb pushed a commit to qborisb/directus that referenced this pull request Aug 31, 2022
…s#15144)

* update open state if already initialized

* prevent group rendering with default props before data is loaded

* prevent default field options before values are loaded
qborisb pushed a commit to qborisb/directus that referenced this pull request Aug 31, 2022
…s#15144)

* update open state if already initialized

* prevent group rendering with default props before data is loaded

* prevent default field options before values are loaded
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conditions do not work in the group box
3 participants