-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revisions for CRUD operations with $full #15467
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. It works well for the item update operation. 👍
This change should be propagated to all operations that has permissions === '$full'
. Let's also extract the customAccountability
conditional code-block into a util such as getOperationCustomAccountability
. 🙂
Right will push an update shortly |
Co-authored-by: ian <licitdev@gmail.com>
…ete and update items operations
@licitdev I've moved the codeblock into So that calling:
returns the block I had above, this lets it work the same as public, trigger or anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
* revisions for CRUD operations with $full * Update api/src/operations/item-update/index.ts Co-authored-by: ian <licitdev@gmail.com> * add system role to getAccountabilityForRole and add it to create, delete and update items operations * Whitespace consistency Co-authored-by: ian <licitdev@gmail.com>
* revisions for CRUD operations with $full * Update api/src/operations/item-update/index.ts Co-authored-by: ian <licitdev@gmail.com> * add system role to getAccountabilityForRole and add it to create, delete and update items operations * Whitespace consistency Co-authored-by: ian <licitdev@gmail.com>
Description
This PR addresses the fact that when no user is set in flows aka system or
$full
permissions operations, then the app didn't store revisions to track the changes.Originally, it set the
customAccountability
to null, now it will set it as follows:This leads to revisions being created by the flow so we can track the changes.
Addresses #15345, fixes #15346
Type of Change
Requirements Checklist
If adding a new feature: