Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom subject for password reset email #15590

Closed

Conversation

HuldaCZ
Copy link

@HuldaCZ HuldaCZ commented Sep 15, 2022

Description

Add the possibility to set custom subject for password reset email.
I just find out, that it's not possible to pass cutom subject for password reset email.

While auth service requestPasswordReset support this feature, the API doesn't.

So I just updated the API to pass the subject from request to the service.

No issue is open for this small change.

Fixes #

Type of Change

  • Bugfix
  • Improvement
  • New Feature
  • Refactor / codestyle updates
  • Other, please describe:

Requirements Checklist

  • New / updated tests are included
  • All tests are passing locally
  • Performed a self-review of the submitted code

If adding a new feature:

  • Documentation was added/updated. PR:

@paescuj
Copy link
Member

paescuj commented Sep 15, 2022

We had a similar pull request in the past which has been rejected mostly for security reasons, see #7372.

@HuldaCZ
Copy link
Author

HuldaCZ commented Sep 15, 2022

We had a similar pull request in the past which has been rejected mostly for security reasons, see #7372.

Thank you. I understand that, it will not be implemented in this way.

So is anyone working on the implementation through translations?

@HuldaCZ HuldaCZ closed this Sep 15, 2022
@paescuj
Copy link
Member

paescuj commented Sep 15, 2022

So is anyone working on the implementation through translations?

I guess it's somewhere on the roadmap, but I'm not sure about it...

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants