Add 'loading' field to images in wysiwyg editor #15791
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I wonder why URL wasn't capitalized per our Title Formatter. Also, I think one of those first two fields should be full with and we move the loading field up so the form feels more balanced. |
added 2 commits
October 2, 2022 18:57
|
yep good idea, I pushed the modification :) |
br41nslug
requested changes
Oct 4, 2022
There was a problem hiding this comment.
Thanks for your contribution 😄 lets remove api/directus-sqlite however which im assuming is an accidentally committed SQLite database.
Comment on lines
+218
to
+221
| import VSelect from '@/components/v-select/v-select.vue'; | ||
| import VItem from '@/components/v-item.vue'; | ||
| import VSelect1 from '@/components/v-select/v-select.vue'; | ||
| import SelectDropdown from '../select-dropdown/select-dropdown.vue'; |
There was a problem hiding this comment.
These are not needed as v-select is registered globally.
Suggested change
| import VSelect from '@/components/v-select/v-select.vue'; | |
| import VItem from '@/components/v-item.vue'; | |
| import VSelect1 from '@/components/v-select/v-select.vue'; | |
| import SelectDropdown from '../select-dropdown/select-dropdown.vue'; |
| @@ -214,7 +229,7 @@ type CustomFormat = { | |||
| }; | |||
|
|
|||
| export default defineComponent({ | |||
| components: { Editor }, | |||
| components: { Editor, VSelect }, | |||
There was a problem hiding this comment.
Suggested change
| components: { Editor, VSelect }, | |
| components: { Editor }, |
| @@ -24,6 +24,7 @@ export type SettingsStorageAssetPreset = { | |||
| withoutEnlargement: boolean | null; | |||
| format: 'jpeg' | 'png' | 'webp' | 'tiff' | null; | |||
| transforms: any[] | null; | |||
| loading: string | null; | |||
There was a problem hiding this comment.
Suggested change
| loading: string | null; | |
| loading: 'lazy' | 'eager' | null; |
|
Closing this for now, as the review has gone ignored |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a
loadingfield when uploading images with wysiwygFixes #15790
Type of Change
Requirements Checklist
If adding a new feature: