Add support for s3 ServerSideEncryption #15952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rijkvanzanten
approved these changes
Oct 12, 2022
|
Thanks @rperon, and welcome to the project! ❤️ |
|
What are valid options for this variable? I have an AWS SSE-S3 encrypted bucket which I want to access. |
It's an option from aws-sdk/client-s3. From what I can tell, it's either |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following discussion #15203, this PR add the support for ServerSideEncryption through the environnement variables STORAGE_S3_SERVER_SIDE_ENCRYPTION .
As this is my first PR on this project, I'm available for any modification / clarification. :)
Type of Change
Requirements Checklist
If adding a new feature: