CLI quickstart: Drop asking for database connection parameters in favor of connection string

[jpizzle34]

Description

Fixes #16066

Type of Change

• Bugfix
• Improvement
• New Feature
• Refactor / codestyle updates
• Other, please describe:

Requirements Checklist

• New / updated tests are included
• All tests are passing locally
• Performed a self-review of the submitted code

If adding a new feature:

• Documentation was added/updated. PR:

[rijkvanzanten]

Is it common for all these databases to rely on a connection string? From what I understand, Oracle relies on a "connect string" (instead of "connection string"), and for mysql/mssql is still more common to use parameters right? 🤔

(Also lets use camelCase for variable names in the codebase 👍🏻 )

[br41nslug]

I'd say using separate parameters is still very common among webdevelopers. Some accompanying docs would be needed to instruct users how to build such a connection string for engines that don't provide it on startup like MySQL.

[connorwinston]

@rijkvanzanten Another thought, what if we kept the separate parameters...but the first parameter is Host or Connection URL and then we detect if it is a connection string skip the rest of the parameters? Allows people to use both ways.

[rijkvanzanten]

@rijkvanzanten Another thought, what if we kept the separate parameters...but the first parameter is Host or Connection URL and then we detect if it is a connection string skip the rest of the parameters? Allows people to use both ways.

In that case, I'd rather start with a question:

Use:
(•) Connection string
( ) Individual Parameters

But tbh, it feels like we can have smart enough defaults by using connection string for postgres/cockroach/oracle, and parameters for everything else

[connorwinston]

That makes more sense, however, I wonder how this will affect people used to the default values? With this change won't they have to make their own connection string and there will be no defaults?

[jpizzle34]

Is it common for all these databases to rely on a connection string? From what I understand, Oracle relies on a "connect string" (instead of "connection string"), and for mysql/mssql is still more common to use parameters right? thinking

(Also lets use camelCase for variable names in the codebase 👍🏻 )

Yes you're right. I'll make those updates today :)

[jpizzle34]

@rijkvanzanten Another thought, what if we kept the separate parameters...but the first parameter is Host or Connection URL and then we detect if it is a connection string skip the rest of the parameters? Allows people to use both ways.

In that case, I'd rather start with a question:

Use:
(•) Connection string
( ) Individual Parameters

But tbh, it feels like we can have smart enough defaults by using connection string for postgres/cockroach/oracle, and parameters for everything else

I'm for this. Supporting both connection params and individual params, by asking the question after the user select their DB client.

[BrianRonin]

I'm not able to connect to cockroachlabs hope this solves it

[rijkvanzanten]

Closing this for now as the suggested solution doesn't cover all use cases. See the thread here! 🙂 #16093 (review)