Allow env access in Flows Run Script operation

[licitdev]

Description

Implements #16108. Allow access to environment variables via data['$env'] or data.$env or process.env in Flows Run Script operation.

Type of Change

• Bugfix
• Improvement
• New Feature
• Refactor / codestyle updates
• Other, please describe:

Requirements Checklist

• New / updated tests are included
• All tests are passing locally
• Performed a self-review of the submitted code

If adding a new feature:

• Documentation was added/updated. PR: https://github.com/directus/docs/pull/185

[br41nslug]

Looks like a solid approach to me 😄 I am wondering tho if we should stay on the safe side and block KEY/SECRET (or possibly database credentials) from being "allowed" 🤔

[rijkvanzanten]

should stay on the safe side and block KEY/SECRET (or possibly database credentials) from being "allowed" 🤔

I don't think that's necessary. That configuration is in the env vars, which is sysadmin only. That's already "you have access to everything" access, so it's a free for all at that point.

[licitdev]

The $env variable is consistent with other variables such as $last, $accountability and $trigger where it can be used within the options.

There are numerous ways to accessed the variables in the run script operation as follows.
Should the global variable be removed?

module.exports = async function (data) {
	// The following logs the same value
	console.log(process.env); // Node.js method
	console.log($env); // Global variable
	console.log({{$env}}); // Parsed options
	console.log(data.$env) // Passed data, or data['$env']
};

[br41nslug]

Should the global variable be removed?

Yeah i think that one might be a bit overkill, none of the others are directly accessible as global variables right?

[licitdev]

@br41nslug That has been added that in #16180 🤔

[br41nslug]

Ah i did not know that 😓 never mind then

[licitdev]

@br41nslug The global variable in the run script operation is indeed overkill and hard to document. Removed! 😄

[nickrum]

I'm wondering if we want to remove the exec-operation-specific handling of env vars completely to make it consistent with the other operations 🤔

[br41nslug]

Have change requests been resolved to merge this one @licitdev ?

[licitdev]

@br41nslug Yes they were.

Refactored.