Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken preset when user does not have the necessary permissions on related collections #16119

Merged
merged 2 commits into from
Oct 24, 2022

Conversation

jaads
Copy link
Member

@jaads jaads commented Oct 22, 2022

Description

Fixes #12469

Type of Change

  • Bugfix
  • Improvement
  • New Feature
  • Refactor / codestyle updates
  • Other, please describe:

Requirements Checklist

  • New / updated tests are included
  • All tests are passing locally
    Regardless of my changes, I wasn't able to run e2e tests locally - see Unable to run e2e tests locally #16097. But all unit tests in /app passed when using pnpm test within /app
    EDIT: The issue with my local tests is resolved now. All tests passed locally
  • Performed a self-review of the submitted code

If adding a new feature:

  • Documentation was added/updated. PR:

@azrikahar azrikahar changed the title Fix broken preset (#12469) Fix broken preset when user does not have the necessary permissions on related collections Oct 24, 2022
Copy link
Member

@br41nslug br41nslug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rijkvanzanten rijkvanzanten self-assigned this Oct 24, 2022
@rijkvanzanten rijkvanzanten added this to the Next Release milestone Oct 24, 2022
@rijkvanzanten rijkvanzanten merged commit 51bb1f6 into directus:main Oct 24, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collection "table" preset breaks when user lacks permission on related collection
3 participants