Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Small Release workflow clean-up" #16120

Merged
merged 1 commit into from
Oct 22, 2022
Merged

Revert "Small Release workflow clean-up" #16120

merged 1 commit into from
Oct 22, 2022

Conversation

rijkvanzanten
Copy link
Member

Reverts #16083

Somehow, the usage of the cache seems to make npm think (correctly or otherwise) that the tarball packed versions of the packages are corrupt, preventing the docker images from being built. We'll revert this optimization until we figure out what's going on there

@rijkvanzanten rijkvanzanten merged commit c2ee8c2 into main Oct 22, 2022
@rijkvanzanten rijkvanzanten deleted the revert-16083-small-workflow-cleanup branch October 22, 2022 17:05
rijkvanzanten pushed a commit that referenced this pull request Oct 24, 2022
@paescuj
Fix path for packages in package.json used for Docker image (#16141)
5507ca3 
* Use basename to get relative path for packages

* Revert "Revert "Small `Release` workflow clean-up (#16083)" (#16120)"

This reverts commit c2ee8c2.
@rijkvanzanten rijkvanzanten added this to the Next Release milestone Nov 1, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
🍰 Optimization
Projects
None yet
Milestone
v9.20.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@rijkvanzanten