Fix field/collection translated name not resetting after being removed #16131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
licitdev
reviewed
Oct 24, 2022
|
Can we sneak in a unit test or two for those stores? 🙂 |
Added! |
rijkvanzanten
approved these changes
Oct 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #16128
Changes
Fix field translation not being reset when the translation(s) gets removed
chrome_5hLg2co7Rc.mp4
Applied same fix for collections
chrome_0xALft1UZg.mp4
Removed unused translations in
settings.yamltranslationsneeds to be an array and the nested keys should belanguage + translation, notlanguage + translations(plural). Hence these translations are never used, and it seems like they are outdated.Type of Change
Requirements Checklist
If adding a new feature: