Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Paste Raw Value not staging field edit #16132

Merged
merged 2 commits into from
Oct 24, 2022
Merged

Fix Paste Raw Value not staging field edit #16132

merged 2 commits into from
Oct 24, 2022

Conversation

azrikahar
Copy link
Contributor

Description

Fixes #16130

When using Paste Raw Value in a form, it is now not staging the field's edit, hence the save button is disabled.

This is due to the change in #15868, which fixes raw value editor from emitting value on every keystrokes, but it in turn made pasting raw value doesn't stage the value as well.

Type of Change

  • Bugfix
  • Improvement
  • New Feature
  • Refactor / codestyle updates
  • Other, please describe:

Requirements Checklist

  • New / updated tests are included
  • All tests are passing locally
  • Performed a self-review of the submitted code

If adding a new feature:

  • Documentation was added/updated. PR:

Copy link
Member

@licitdev licitdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@licitdev licitdev merged commit efe7dce into main Oct 24, 2022
@licitdev licitdev deleted the fix/16130 branch October 24, 2022 16:55
@licitdev licitdev added this to the Next Release milestone Oct 24, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pasting values does not emit change and hence can not save
2 participants