Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GraphQLBigInt type #16157

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Add GraphQLBigInt type #16157

merged 1 commit into from
Oct 25, 2022

Conversation

licitdev
Copy link
Member

@licitdev licitdev commented Oct 25, 2022

Description

Fixes #15663. BigInt values remains to be of string output type as per #12688.

GraphQLBigInt has the same max value of 9007199254740991, which is the Number.MAX_SAFE_INTEGER, which has to be passed as a string.
GraphQLInt has a max value of 2147483647.

BigInt fields can be aggregated in GraphQL.

Screen.Recording.2022-10-25.at.5.44.43.PM.mov

Type of Change

  • Bugfix
  • Improvement
  • New Feature
  • Refactor / codestyle updates
  • Other, please describe:

Requirements Checklist

  • New / updated tests are included
  • All tests are passing locally
  • Performed a self-review of the submitted code

If adding a new feature:

  • Documentation was added/updated. PR:

@rijkvanzanten rijkvanzanten merged commit e7a5782 into main Oct 25, 2022
@rijkvanzanten rijkvanzanten deleted the fix/graphql-bigint branch October 25, 2022 21:04
@licitdev licitdev added this to the Next Release milestone Oct 26, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to aggregate bigInteger fields in GraphQL as they are typed as string
2 participants