Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set readonly value during initialisation of raw editor #16163

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

licitdev
Copy link
Member

Description

Fixes #16162. Sets the readOnly option during initialisation of CodeMirror.

A similar configuration is already in place for input-code.

const cmOptions = computed<Record<string, any>>(() => {
return Object.assign(
{},
defaultOptions,
{
lineNumbers: props.lineNumber,
lineWrapping: props.lineWrapping,
readOnly: readOnly.value,

Type of Change

  • Bugfix
  • Improvement
  • New Feature
  • Refactor / codestyle updates
  • Other, please describe:

Requirements Checklist

  • New / updated tests are included
  • All tests are passing locally
  • Performed a self-review of the submitted code

If adding a new feature:

  • Documentation was added/updated. PR:

Copy link
Contributor

@azrikahar azrikahar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@azrikahar azrikahar added this to the Next Release milestone Oct 25, 2022
@azrikahar azrikahar merged commit 12a425a into main Oct 25, 2022
@azrikahar azrikahar deleted the fix/disabled-raw-editable branch October 25, 2022 14:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raw value modal is editable when disabled
2 participants