Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name to routes with empty path #16174

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Add name to routes with empty path #16174

merged 2 commits into from
Oct 26, 2022

Conversation

azrikahar
Copy link
Contributor

Description

Fixes vue router warnings for routes with empty path '' and no name.

#16052 bumped vue-router from 4.0.15 to 4.1.5, and this warning is added in vue-router 4.1.0.

chrome_vxmLRW36zw

Type of Change

  • Bugfix
  • Improvement
  • New Feature
  • Refactor / codestyle updates
  • Other, please describe:

Requirements Checklist

  • New / updated tests are included
  • All tests are passing locally
  • Performed a self-review of the submitted code

If adding a new feature:

  • Documentation was added/updated. PR:

@licitdev licitdev self-assigned this Oct 26, 2022
Copy link
Member

@licitdev licitdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~ 🚀

@licitdev licitdev merged commit 107c6d2 into main Oct 26, 2022
@licitdev licitdev deleted the fix-router-warnings branch October 26, 2022 05:53
@licitdev licitdev added this to the Next Release milestone Oct 26, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants