Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove authorization header from token refresh request #16199

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

licitdev
Copy link
Member

Description

Fixes #16188. Remove the Authorization header by setting undefined to prevent the default symbol value from being applied.
Note: this issue surfaces only on the production build.

image

Type of Change

  • Bugfix
  • Improvement
  • New Feature
  • Refactor / codestyle updates
  • Other, please describe:

Requirements Checklist

  • New / updated tests are included
  • All tests are passing locally
  • Performed a self-review of the submitted code

If adding a new feature:

  • Documentation was added/updated. PR:

Copy link
Member

@br41nslug br41nslug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this fixes the logout issue 😄 but Azri brings up a good point

app/src/auth.ts Show resolved Hide resolved
@azrikahar azrikahar added this to the Next Release milestone Oct 27, 2022
@azrikahar azrikahar self-assigned this Oct 27, 2022
@azrikahar azrikahar merged commit 72b5e5c into main Oct 27, 2022
@azrikahar azrikahar deleted the fix/axios-auth-header branch October 27, 2022 14:11
@u12206050
Copy link
Contributor

Need this as a hotfix asap. Have a ton of users complaining to me about this now, if no hotfix is possible then I'll have to revert but that would be a pity. :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After last update (9.19.2), Directus logs out users after about 15 min. repeatedly.
4 participants