fix validating of date only values (fixes calendar end display) #16200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i also tested all possible scenarios in the UI with different field values. looks good now. |
azrikahar
approved these changes
Oct 28, 2022
There was a problem hiding this comment.
LGTM! I've wrongly interpreted parse() being the culprit in #12957, when it is actually the format() afterwards (even the console error showed it as format())! So the current ordering in your PR by parsing then checking isValid is definitely the way to go. 👍
Checked null end date values, as well as the following example:
| Before | After |
|---|---|
 |
 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15844
Type of Change
Requirements Checklist
If adding a new feature: