Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert mapbox-gl to latest v1 #16204

Merged
merged 2 commits into from
Oct 29, 2022
Merged

Revert mapbox-gl to latest v1 #16204

merged 2 commits into from
Oct 29, 2022

Conversation

licitdev
Copy link
Member

Description

Fixes #16185. Revert update mapbox-gl from next major version.

Type of Change

  • Bugfix
  • Improvement
  • New Feature
  • Refactor / codestyle updates
  • Other, please describe:

Requirements Checklist

  • New / updated tests are included
  • All tests are passing locally
  • Performed a self-review of the submitted code

If adding a new feature:

  • Documentation was added/updated. PR:

br41nslug
br41nslug approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@br41nslug br41nslug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this approach also loads the mapbox tiles correctly 😄

joselcvarela
joselcvarela reviewed Oct 28, 2022
View reviewed changes
pnpm-lock.yaml Outdated Show resolved Hide resolved
@rijkvanzanten rijkvanzanten enabled auto-merge (squash) October 28, 2022 11:42
@licitdev licitdev added this to the Next Release milestone Oct 28, 2022
@rijkvanzanten rijkvanzanten merged commit 1de75ac into main Oct 29, 2022
@rijkvanzanten rijkvanzanten deleted the dep/maplibre-gl branch October 29, 2022 19:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joselcvarela joselcvarela joselcvarela approved these changes

@br41nslug br41nslug br41nslug approved these changes

@rijkvanzanten rijkvanzanten Awaiting requested review from rijkvanzanten

Assignees
No one assigned
Labels
🍰 Bug
Projects
None yet
Milestone
v9.20.0
Development

Successfully merging this pull request may close these issues.

Map interface/layout cannot be rendered after adding Mapbox Access Token in Project Settings
4 participants
@licitdev @br41nslug @joselcvarela @rijkvanzanten