Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert some trace logs to warnings in OAuth flows #16213

Merged
merged 3 commits into from
Oct 29, 2022
Merged

Convert some trace logs to warnings in OAuth flows #16213

merged 3 commits into from
Oct 29, 2022

Conversation

aidenfoxx
Copy link
Contributor

@aidenfoxx aidenfoxx commented Oct 27, 2022

Description

We've been getting more topics recently relating to issues with OpenID and OAuth providers. Not that I believe people are particularly attentive of logs, but more information might be useful in these cases.

There are probably some points in the docs that could also be clarified to improve things such as:

  • Explaining the different cookie policies in Single Sign-On (SSO)
  • Making the SSO Examples more prominent and plug-and-play, with stuff like "AUTO_REGISTER" and "DEFAULT_ROLE_ID"
  • Clarify the "callback" URL, since I think that's barely documented

Mostly writing those points down here so I don't lose them.

Type of Change

  • Bugfix
  • Improvement
  • New Feature
  • Refactor / codestyle updates
  • Other, please describe:

Requirements Checklist

  • New / updated tests are included
  • All tests are passing locally
  • Performed a self-review of the submitted code

If adding a new feature:

  • Documentation was added/updated. PR:

@rijkvanzanten rijkvanzanten merged commit 2adbb3b into directus:main Oct 29, 2022
@rijkvanzanten rijkvanzanten added this to the Next Release milestone Oct 29, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants