Handle "form_post" OAuth and OpenID responses (fix for Apple OpenID) #16231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidenfoxx
commented
Oct 30, 2022
aidenfoxx
commented
Oct 30, 2022
|
@rijkvanzanten I've tested this with "form_post" via Google, but I've not tested Apple (because fuck paying £79 for the privilege). SMH Apple! 😠 If you're able to test the configuration in the attached Docs PR, it would be appreciated. |
aidenfoxx
commented
Oct 30, 2022
rijkvanzanten
approved these changes
Nov 1, 2022
aidenfoxx
changed the title
aidenfoxx
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should allow both standard and "form_post" response modes from OpenID and OAuth providers. Adding the following option to a provider config will trigger the new flow:
AUTH_PROVIDER_PARAMS="{"response_mode":"form_post"}".This is required by Apple to return the user email.
Also removed a superfluous check in the router which is covered by
getUserID, and add a missing "state" variable check related to that.Type of Change
Requirements Checklist
If adding a new feature: