Clean-up after Jest to Vitest switch in API

[paescuj]

Description

Just some corrections after the Jest to Vitest switch in the API (#16263).

@rijkvanzanten I think I prefer to have the tests type checked as well, but I'm unsure about the best practice here... I included the tests again (in tsconfig.json) and fixed the type errors, but if you prefer to exclude them I will gladly undo it!

• Bugfix
• Improvement
• New Feature
• Refactor / codestyle updates
• Other, please describe:

Requirements Checklist

• New / updated tests are included
• All tests are passing locally
• Performed a self-review of the submitted code

If adding a new feature:

• Documentation was added/updated. PR:

[rijkvanzanten]

@paescuj I'd like type checking enabled in tests, as long as they're not included in the output build

[paescuj]

@paescuj I'd like type checking enabled in tests, as long as they're not included in the output build

Okay, great! Actually, with #16374 those files are now excluded from the published package:

directus/api/package.json

Lines 73 to 77 in df495ed

	"files": [
	"dist",
	"!**/*.test.js",
	"!**/__*__/"
	],

Or do you mean to also not having them in the dist folder in the local dev environment? Edit: In that case we could, for example, use two different tsconfig.js files - one for testing & one for building

[rijkvanzanten]

Ah right on, that's all we need then! I don't mind them existing in local dist, as long as we don't upload them to npm needlessly