Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize value in comment-input #16471

Merged
merged 1 commit into from Nov 16, 2022
Merged

Sanitize value in comment-input #16471

merged 1 commit into from Nov 16, 2022

Conversation

azrikahar
Copy link
Contributor

Description

Fixes #16469

<comment-input
v-if="editing"
:existing-comment="activity"
:primary-key="primaryKey"
:collection="collection"
:refresh="refresh"
:previews="userPreviews"
@cancel="cancelEditing"
/>
<div v-else v-md="{ value: activity.display, target: '_blank' }" class="content selectable" />

Currently when a comment is being displayed, it is sanitized within the v-md directive, however when it's passed to <comment-input> as is. The passed value should be sanitized as well.

Type of Change

  • Bugfix
  • Improvement
  • New Feature
  • Refactor / codestyle updates
  • Other, please describe:

Requirements Checklist

  • New / updated tests are included
  • All tests are passing locally
  • Performed a self-review of the submitted code

If adding a new feature:

  • Documentation was added/updated. PR:

@rijkvanzanten rijkvanzanten merged commit 0859102 into main Nov 16, 2022
@rijkvanzanten rijkvanzanten deleted the issue/16469 branch November 16, 2022 15:31
@rijkvanzanten rijkvanzanten added this to the Next Release milestone Nov 17, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants