Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove named timezone usage on MySQL #16499

Merged
merged 1 commit into from Nov 18, 2022
Merged

Remove named timezone usage on MySQL #16499

merged 1 commit into from Nov 18, 2022

Conversation

licitdev
Copy link
Member

Description

Resolves #16494. The usage of named timezones in MySQL may require manual population depending on how / where it's installed.

When tested in the MySQL Docker container, issue did not surface.

image

Ref: https://dev.mysql.com/doc/refman/8.0/en/time-zone-support.html

Type of Change

  • Bugfix
  • Improvement
  • New Feature
  • Refactor / codestyle updates
  • Other, please describe:

Requirements Checklist

  • New / updated tests are included
  • All tests are passing locally
  • Performed a self-review of the submitted code

If adding a new feature:

  • Documentation was added/updated. PR:

br41nslug
br41nslug reviewed Nov 18, 2022
View reviewed changes
Copy link
Member

@br41nslug br41nslug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can only confirm the change doesnt break date handling in MySQL 8 as i have not been able to reproduce the original issue situation

@rijkvanzanten rijkvanzanten merged commit 06aca33 into main Nov 18, 2022
@rijkvanzanten rijkvanzanten deleted the fix/mysql-named-tz branch November 18, 2022 16:46
@licitdev licitdev mentioned this pull request Nov 19, 2022
Closed
@rijkvanzanten rijkvanzanten added this to the Next Release milestone Nov 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@br41nslug br41nslug br41nslug left review comments

@rijkvanzanten rijkvanzanten rijkvanzanten approved these changes

Assignees
No one assigned
Labels
🍰 Improvement 🕋 MySQL
Projects
None yet
Milestone
v9.21.1
Development

Successfully merging this pull request may close these issues.

All Datetime function return null in API call
3 participants
@licitdev @rijkvanzanten @br41nslug