Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide related fields without read permissions #16832

Merged
merged 14 commits into from Feb 24, 2023
Merged

Hide related fields without read permissions #16832

merged 14 commits into from Feb 24, 2023

Conversation

br41nslug
Copy link
Member

@br41nslug br41nslug commented Dec 15, 2022

Description

Added an extra check in the usePermissions composable checking the field read permissions when retrieving related fields in the drawer.

Fixes #16732
Fixes ENG-116

Type of Change

  • Bugfix
  • Improvement
  • New Feature
  • Refactor / codestyle updates
  • Other, please describe:

Requirements Checklist

  • New / updated tests are included
  • All tests are passing locally
  • Performed a self-review of the submitted code

If adding a new feature:

  • Documentation was added/updated. PR:

@br41nslug br41nslug marked this pull request as ready for review January 18, 2023 16:38
@br41nslug br41nslug requested a review from Nitwel January 18, 2023 16:41
Copy link
Member

@Nitwel Nitwel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@br41nslug br41nslug requested review from a team, rijkvanzanten and azrikahar and removed request for a team February 23, 2023 13:38
@rijkvanzanten rijkvanzanten merged commit 5ecb996 into main Feb 24, 2023
@rijkvanzanten rijkvanzanten deleted the issue/16732 branch February 24, 2023 17:44
@rijkvanzanten rijkvanzanten added this to the Next Release milestone Feb 28, 2023
meditadvisors pushed a commit to ciso360ai/directus-mod that referenced this pull request Mar 3, 2023
* remove related O2M fields without read permissions

* Added basic test for usePermissions composable

* updated test

---------

Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com>
ThinkZ pushed a commit to ThinkZ/directus-view that referenced this pull request Mar 29, 2023
* remove related O2M fields without read permissions

* Added basic test for usePermissions composable

* updated test

---------

Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forbidden fields in update of a readonly M2M should not show when the M2M is clicked
3 participants