Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permission check for manual sort for full access #17678

Merged
merged 2 commits into from Mar 14, 2023

Conversation

paescuj
Copy link
Member

@paescuj paescuj commented Mar 2, 2023

Description

Follow up on #17446, taking into account when role has update permission on all fields (*).

Fixes ENG-779

Type of Change

  • Bugfix
  • Improvement
  • New Feature
  • Refactor / codestyle updates
  • Other, please describe:

Requirements Checklist

  • New / updated tests are included
  • All tests are passing locally
  • Performed a self-review of the submitted code

If adding a new feature:

  • Documentation was added/updated. PR:

@paescuj paescuj requested review from Nitwel, a team, freekrai and connorwinston and removed request for a team March 2, 2023 10:44
@paescuj paescuj requested a review from azrikahar March 13, 2023 15:01
@azrikahar azrikahar merged commit e87f93f into main Mar 14, 2023
@azrikahar azrikahar deleted the fix-permission-check-for-manual-sort branch March 14, 2023 12:33
@licitdev licitdev added this to the Next Release milestone Mar 14, 2023
meditadvisors pushed a commit to ciso360ai/directus-mod that referenced this pull request May 13, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants