Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle webhook request errors correctly #18080

Merged
merged 2 commits into from
Apr 11, 2023
Merged

Conversation

paescuj
Copy link
Member

@paescuj paescuj commented Apr 6, 2023

Error isn't necessarily of type AxiosError, therefore adding a check and just throw the original error if it is not the case.

Closes #18068

@paescuj paescuj marked this pull request as ready for review April 11, 2023 20:30
@rijkvanzanten rijkvanzanten merged commit 5205a8a into main Apr 11, 2023
6 checks passed
@rijkvanzanten rijkvanzanten deleted the check-request-error branch April 11, 2023 20:49
@rijkvanzanten rijkvanzanten added this to the Next Release milestone Apr 13, 2023
hanneskuettner pushed a commit to hanneskuettner/directus that referenced this pull request Apr 18, 2023
meditadvisors pushed a commit to ciso360ai/directus-mod that referenced this pull request May 13, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message swallowed in webhook operation
2 participants