Get Directus version directly via filesystem from directus package
#18164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paescuj
requested review from
a team,
br41nslug,
nickrum,
connorwinston and
rijkvanzanten
and removed request for
a team
paescuj
changed the title
directus package
rijkvanzanten
approved these changes
Apr 16, 2023
hanneskuettner
pushed a commit
to hanneskuettner/directus
that referenced
this pull request
Apr 18, 2023
meditadvisors
pushed a commit
to ciso360ai/directus-mod
that referenced
this pull request
May 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetch current Directus version directly (via filesystem, not export) from the package.json file of the
directuspackage and expose it as a Vite constant to the app.Gets rid of the current cyclic dependency setup:
WARN There are cyclic workspace dependencies: directus/directus/api, directus/directus/app, directus/directus/directus