Fix tabular not properly dealiasing items #18186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nitwel
requested review from
rijkvanzanten,
br41nslug and
connorwinston
and removed request for
a team
rijkvanzanten
requested changes
Apr 14, 2023
|
@rijkvanzanten Going back to the discussion we had on Discord, your idea of being able to apply the translations display to any field wouldn't work at the moment as the display needs to configure which fields it should load, but the problem here is that you can only specify fields relative to your field so you can't load fields on the same level meaning, the display wouldn't be able to access the What I did now is to remove the hacky logic so we can fix this for now and figure out a proper way to support translations display on none translations fields, meaning that for now we will only show it as an array like so: |
rijkvanzanten
approved these changes
Apr 21, 2023
meditadvisors
pushed a commit
to ciso360ai/directus-mod
that referenced
this pull request
May 13, 2023
* Fix tabular not properly dealiasing items * run linter * remove translations edgecase * Fix linter warnings * Remove unused var --------- Co-authored-by: rijkvanzanten <rijkvanzanten@me.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that when merging the item returned from the api to replace alaised fields with their original names, I didn't take into account that the field without an alias could override the dealiased field, thus resulting in the wrong item.
closes #18181