Publish all types from packages/* #18211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanneskuettner
force-pushed
the
feat/publish-all-the-types
branch
3 times, most recently
from
eefab53
to
423af62
Compare
hanneskuettner
force-pushed
the
feat/publish-all-the-types
branch
2 times, most recently
from
a7e9b6c
to
ed2a854
Compare
hanneskuettner
force-pushed
the
feat/publish-all-the-types
branch
from
ed2a854
to
e179706
Compare
- Remove 'useTabs' so prettier will not override settings from editorconfig - Remove settings in editorconfig which match the defaults anyway
hanneskuettner
commented
Apr 17, 2023
paescuj
requested changes
Apr 17, 2023
paescuj
reviewed
Apr 17, 2023
hanneskuettner
force-pushed
the
feat/publish-all-the-types
branch
from
21f2323
to
024de15
Compare
paescuj
reviewed
Apr 17, 2023
As far as I can tell, it was simply forgotten to do so.
No, I don't think so. I'd only expose the types for packages that are actually intended for use and I don't see why this would be the case for these packages. |
paescuj
requested review from
a team,
nickrum,
connorwinston and
azrikahar
and removed request for
a team
azrikahar
approved these changes
Apr 17, 2023
hanneskuettner
added a commit
to hanneskuettner/directus
that referenced
this pull request
Apr 18, 2023
* Publish all types in packages/* * Re-add main entrypoints and add types * Clean-up prettier config / editorconfig - Remove 'useTabs' so prettier will not override settings from editorconfig - Remove settings in editorconfig which match the defaults anyway * Remove types entrypoint again * Update packages/schema/package.json --------- Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
meditadvisors
pushed a commit
to ciso360ai/directus-mod
that referenced
this pull request
May 13, 2023
* Publish all types in packages/* * Re-add main entrypoints and add types * Clean-up prettier config / editorconfig - Remove 'useTabs' so prettier will not override settings from editorconfig - Remove settings in editorconfig which match the defaults anyway * Remove types entrypoint again * Update packages/schema/package.json --------- Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18209
This is basically a continuation of #18180
Additionally this PR removes themainentrypoint and replaces them with a properexportsfield as this project is now ESM only anyways and the exports field takes precedence over themainfield as per https://nodejs.org/api/packages.html#package-entry-pointsEdit: Turns out TypeScript needs to have
"moduleResolution": "nodenext"enabled for the exports to work (which is available since TS 4.7). So this would mean a breaking change in extensions. I've left themainentrypoint intact and added an additionaltypesentrypoint in addition to the future proofexports.I also removed the 2 spaces rule for
package.jsonfrom the.editorconfigsince my editor seemed to be the only one respecting it and all of thepackage.jsonfiles used tabs so far.Open Questions:
storage-driver-*types also be exported?