-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated uses of useAliasFields #18267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the useAliasFields to only apply the alias when nessesary.
Added tests!
Made a generic helper function so composable is easier to work with.
Looks good to me but I also made a lot of changes so maybe 2 others should review too. 😄
🦋 Changeset detectedLatest commit: 6e84635 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
* updated uses of useAliasFields * use fields instead * updated ternary check * remove dealiasing * Linty lint * temporary changes * finish alias cleanup * Fix linter warnings * fixed imports from merge * removed unsed variables * Add changeset --------- Co-authored-by: Nitwel <mail@nitwel.de> Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch> Co-authored-by: rijkvanzanten <rijkvanzanten@me.com> Co-authored-by: Jan Arends <jan.arends@mailbox.org>
Description
the
useAliasFields
composable was updated in #17799 however 2 uses of this composable were not updated accordingly.Fixes #18206
Type of Change
If adding a new feature: