Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated uses of useAliasFields #18267

Merged
merged 16 commits into from
May 2, 2023
Merged

updated uses of useAliasFields #18267

merged 16 commits into from
May 2, 2023

Conversation

br41nslug
Copy link
Member

Description

the useAliasFields composable was updated in #17799 however 2 uses of this composable were not updated accordingly.

Fixes #18206

Type of Change

  • Bugfix
  • Improvement
  • New Feature
  • Refactor / codestyle updates
  • Other, please describe:

If adding a new feature:

  • Documentation was added/updated. PR:

@br41nslug br41nslug requested a review from Nitwel April 20, 2023 12:50
@br41nslug br41nslug requested review from a team, rijkvanzanten and nickrum and removed request for a team April 20, 2023 13:02
Copy link
Member

@Nitwel Nitwel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the useAliasFields to only apply the alias when nessesary.
Added tests!
Made a generic helper function so composable is easier to work with.

Looks good to me but I also made a lot of changes so maybe 2 others should review too. 😄

@rijkvanzanten rijkvanzanten requested review from a team and jaads and removed request for a team April 21, 2023 18:34
@changeset-bot
Copy link

changeset-bot bot commented May 1, 2023

🦋 Changeset detected

Latest commit: 6e84635

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@directus/app Patch
@directus/api Patch
directus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rijkvanzanten rijkvanzanten merged commit 8a77280 into main May 2, 2023
4 checks passed
@rijkvanzanten rijkvanzanten deleted the fix-18206 branch May 2, 2023 19:23
@rijkvanzanten rijkvanzanten added this to the Next Release milestone May 4, 2023
meditadvisors pushed a commit to ciso360ai/directus-mod that referenced this pull request May 13, 2023
* updated uses of useAliasFields

* use fields instead

* updated ternary check

* remove dealiasing

* Linty lint

* temporary changes

* finish alias cleanup

* Fix linter warnings

* fixed imports from merge

* removed unsed variables

* Add changeset

---------

Co-authored-by: Nitwel <mail@nitwel.de>
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
Co-authored-by: rijkvanzanten <rijkvanzanten@me.com>
Co-authored-by: Jan Arends <jan.arends@mailbox.org>
smenardstingray added a commit to StingrayDigital/directus that referenced this pull request Dec 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display template doesn't work in calendar layout
5 participants