Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load cjs custom migrations #18385

Merged
merged 5 commits into from
May 2, 2023
Merged

Load cjs custom migrations #18385

merged 5 commits into from
May 2, 2023

Conversation

br41nslug
Copy link
Member

@br41nslug br41nslug commented May 2, 2023

Custom Migrations were only loaded based on the *.js file extension. This PR allows the loading of extra extension types for custom migrations:

  • *.cjs for CommonJS
  • *.mjs for ESM
  • *.js for ESM

Fixes #18359

@changeset-bot
Copy link

changeset-bot bot commented May 2, 2023

🦋 Changeset detected

Latest commit: d5c88fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@directus/api Patch
directus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@br41nslug
Copy link
Member Author

/linear

@github-actions
Copy link

github-actions bot commented May 2, 2023

🤖 Linear issue created! Maintainers can access it here: ENG-932

@br41nslug br41nslug marked this pull request as ready for review May 2, 2023 16:07
@br41nslug br41nslug requested review from a team, paescuj, Nitwel and azrikahar and removed request for a team May 2, 2023 16:09
@paescuj

This comment was marked as resolved.

Copy link
Member

@paescuj paescuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended 👍

@paescuj paescuj merged commit 1fba5eb into main May 2, 2023
7 checks passed
@paescuj paescuj deleted the fix/commonjs-migrations branch May 2, 2023 19:10
@rijkvanzanten rijkvanzanten added this to the Next Release milestone May 4, 2023
meditadvisors pushed a commit to ciso360ai/directus-mod that referenced this pull request May 13, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom migration questions
3 participants